Add command to generate HTML help #1374
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @ErjanGavalji |
| } | ||
|
|
||
| public canExecute(args: string[]): IFuture<boolean> { | ||
| return Future.fromResult(true); |
There was a problem hiding this comment.
Why do you need canExecute method? The idea is to use it when you cannot specify exactly the number (and type) of the allowed parameter. In this case the command will not accept any parameters, so I suggest to remove the canExecute implementation, or I'm missing something here?
Implements #1302
teobugslayer
force-pushed
the
totev/dev-gen-help
branch
from
0f0c9d4 to
099dd7e
Compare
|
👍 |
teobugslayer
added a commit
that referenced
this pull request
Jan 6, 2016
Add command to generate HTML help
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #1302